search

dubinc / dub

Open-source link management infrastructure. Loved by modern marketing teams like Vercel, Raycast, and Perplexity.
https://dub.co
GNU Affero General Public License v3.0
18.9k stars 2.04k forks source link

Cannot delete a link with an asterisk in the path #1324

Open wdhdev opened 1 month ago

wdhdev commented 1 month ago

If you create a short link with * in the slug, when attempting to delete it, the input validation says it is not valid:

image

It seems to be an issue with the pattern HTML attribute on the input field.

Browser: Firefox 131.0

linear[bot] commented 1 month ago

ENG-607 Incorrect input validation on confirm delete

sudipb7 commented 1 month ago

I tested it. If you create a short link with in the slug, for example, `hrsn.link/you'll have to typehrsn.link` to validate the input.

wdhdev commented 1 month ago

Yep, that works, however it is still technically a validation issue that probably should be fixed. Either by disallowing the * character when creating links, or by just somehow fixing the frontend validation for deleting a link with the * character in it.

sudipb7 commented 1 month ago

I guess both are needed as there can be existing links with * and user should not be able to create links like this

ShashankGupta10 commented 4 weeks ago

Can i work on this @steven-tey ?