dubinc / dub

Open-source link management infrastructure
https://dub.co
GNU Affero General Public License v3.0
16.98k stars 1.74k forks source link

Metatags - Edge case: nothing detected on some websites #427

Open pablobarrera opened 8 months ago

pablobarrera commented 8 months ago

Hi, I have been using the metatags api to generate link previews and I found this edge case:

Nothing detected: Link: https://www.fastcompany.com/90970396/how-asking-the-right-3-questions-can-inspire-great-leadership

Metatags don't detect anything:

Screen Shot 2023-10-24 at 11 54 47

LinkPreview.net detects properly:

Screen Shot 2023-10-24 at 11 55 10

And the following cases don't work on both Metatags and LinkPreview.net, I'm not sure if something could be done:

Images don't have a preview https://cdna.artstation.com/p/assets/images/images/002/426/200/4k/helena-butenkova-forest-army-by-acidea-da0bvg4.jpg?1461609843

Nothing detected https://www.inc.com/justin-bariso/emotional-intelligence-how-to-reach-goal-be-successful.html

omkar342 commented 8 months ago

Hi @steven-tey, I would like to fix this issue. Will you please assign this to me?

steven-tey commented 8 months ago

@omkar342 just did – thank you!

pablobarrera commented 8 months ago

I leave two more cases, if you want I could create another issue for these.

Nothing detected: Link: https://www.glassdoor.com/blog/tips-for-building-an-online-personal-brand/?utm_source=newsletter&utm_medium=email&utm_campaign=1023_us_newsletter&utm_content=20231026_personal_brand&cm=EMAIL_LIFECYCLE

Metatags don't detect anything:

Screen Shot 2023-10-30 at 10 47 15

WhatsApp detects properly:

Screen Shot 2023-10-30 at 10 47 41

And for the following one, neither WhatsApp nor LinkPreview.net generates a preview so I'm not sure if something could be done:

Google Drive Images don't have a preview https://drive.google.com/file/d/1Vmo0PnMSPJjnCmHI_A1aaR2KE2lMAC0D/view?usp=sharing