dubo-dubon-duponey / docker-spotify

Librespot container for amd64, arm64, arm/v7, arm/v6 (based on debian:buster-slim)
https://hub.docker.com/r/dubodubonduponey/librespot
MIT License
22 stars 2 forks source link

Update README.md with dockerhub image ? #13

Closed yetanotherjr closed 2 years ago

yetanotherjr commented 2 years ago

Hello !

Could you update the examples in README.md, with the correct image location ?

Currently: ghcr.io/dubo-dubon-duponey/spotify Should be (after following the "about" link): docker.io/dubodubonduponey/librespot

Thanks !

dubo-dubon-duponey commented 2 years ago

Hey there @yetanotherjr

Lately, I have had issues with Docker Hub - rate limiting, blocking pushes, push timeouts.

I still try to also push to Docker Hub of course, but really, ghcr is my main goto these days. Do you have any issues with the ghcr versions?

yetanotherjr commented 2 years ago

Indeed, I'm using docker compose and get this every time:

 ⠿ librespot Error                                                                                                                      0.3s
Error response from daemon: Head "https://ghcr.io/v2/dubo-dubon-duponey/spotify/manifests/latest": unauthorized

docker-compose.yml

version: '3'
services:
  librespot:
    container_name: librespot
#    image: dubodubonduponey/librespot
    image: ghcr.io/dubo-dubon-duponey/spotify
    volumes:
      - /data/docker/librespot/storage/tmp:/tmp
    devices:
      - /dev/snd:/dev/snd
    restart: unless-stopped
    network_mode: host
    environment:
      - NAME=srv.lan
    cap_drop:
      - ALL
    group_add:
      - "29"
    ports:
      - 10042:10042
    command: librespot --initial-volume 100 --enable-volume-normalisation --device hw:CARD=Device
    healthcheck:
      disable: true

When trying to access the URL directly, it shows a 404 page

dubo-dubon-duponey commented 2 years ago

Yes, ghcr does not offer anonymous access IIRC.

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

How to authenticate there is fairly simple though - see above ^

Otherwise, nothing wrong with using the Hub of course - but sometimes the latest version of the image will not be there when I get rate limited / blocked there.

yetanotherjr commented 2 years ago

Thanks for the quick reply ! I'll do the setup on my end, then update you to confirm it works as intended :)

yetanotherjr commented 2 years ago

I created a Personal Access Token with full rights. Login successful but docker pull still failing:

$ docker login ghcr.io
Username: yetanotherjr
Password:
WARNING! Your password will be stored unencrypted in /home/jr/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
$ docker pull ghcr.io/dubo-dubon-duponey/spotify
Using default tag: latest
Error response from daemon: denied

I'll continue checking

Also I just remembered: I used to pull home-assistant core from ghcr.io, and never needed to authenticate. Maybe there's something to configure/update in the projects settings ?

dubo-dubon-duponey commented 2 years ago

You are right. Something is wrong here. Looks like I am not the only one with the issue. Will have to look into this, but cannot focus on that right now.

I guess you should then stick with Docker Hub.

shrugs

dubo-dubon-duponey commented 2 years ago

Moved documentation to point back to Docker Hub. For whatever reason, permissions with ghcr seem to be broken rn.