search

dubreuia / intellij-plugin-save-actions

Supports configurable, Eclipse like, save actions, including "organize imports", "reformat code" and "rearrange code".
MIT License
531 stars 101 forks source link

PHPStorm: External tool argument not passed when called thru Save Actions #352

Open AlanKrygowski opened 3 years ago

AlanKrygowski commented 3 years ago

Describe the bug I have an external tool used to fire a specific package on the file that I currently have opened up. The tool itself uses a $FilePathRelativeToProjectRoot$ argument in order to properly detect the open file, and works properly when called thru Actions, or inside a Quick List with the output being:

path/to/tool.sh relative/path/to/File.php

However, when the action is to be called thru the package's Build Actions, the action itself gets a call, but without the argument, resulting in a call for

path/to/tool.sh

Which, in turn, calls the tool for all files in the project.

I also have the plugin trigger a reformat in the file, and this actually happens only in the focused file, therefore the issue seems strictly connected with being called for the build.

Apart from the argument provided for the external tool, nothing was changed. The external tool works well thru the QuickList (with the proper context).

What triggered the plugin CTRL+S

Versions PhpStorm 2020.3

AlanKrygowski commented 3 years ago

tenor

dubreuia commented 3 years ago

Hello @AlanKrygowski :wave:, thank you for your interest in the plugin, and sorry for taking so long to answer, I'm swamped right now.

There's a lot going on there, I need more info on this. First can you send me a screenshot of your Save Actions config please? And also idea.log when you save (see https://github.com/dubreuia/intellij-plugin-save-actions#files-location).

From what I understand: you're using Save Actions to call a quick list on save, but when your quick list is called, you don't have the parameter. Can you send me a screenshot of your quick list config? Save Actions needs to pass info (parameters...) and probably isn't properly doing it.

Also: quick lists in save actions are VERY beta, there's a lot of things I'm unable to do

AlanKrygowski commented 3 years ago

@dubreuia Hi. Thanks for reaching back. No problem. The above comment was more of a bump than a complaint :D

My config is rather basic, with just the action loaded up, and the formatting turned on image The QL config is also very basic (since the action called is not mine, I had to cover it) image I can't access the idea.log, but I don't recall any changes that could have affected it.

As to the use case, yes, exactly how you described it. I'll add this: Calling the action from the QL in PhpStorm, results in the action working with the proper parameter.

I understand any limitations. Was just trying to clarify if there's anything that could be done for this to work best regards

dubreuia commented 3 years ago

Ok thanks for the info. I'll keep in mind when I work on quick lists, but don't expect a fix on this soon I probably won't have time