search

dubreuia / intellij-plugin-save-actions

Supports configurable, Eclipse like, save actions, including "organize imports", "reformat code" and "rearrange code".
MIT License
529 stars 102 forks source link

Improvement: Add intellij 2021.3 support #387

Closed robert3005 closed 2 years ago

robert3005 commented 2 years ago

In intellij 2021.3 (currently in EAP) the SerializableHasSerialVersionUidFieldInspection has changed the package. I had added new location to the set of the ones being search when initializing.

vanbeekb commented 2 years ago

@dubreuia - Please consider getting this implemented ASAP as the plugin will become unusable once the new version of IntelliJ is released. And those of us running the EAP versions already are unable to use the plugin.

visajkin commented 2 years ago

@dubreuia Any updates on support for 2021.3?

BumbrT commented 2 years ago

@dubreuia

sfragata commented 2 years ago

Hi @robert3005, there was a check fail

robert3005 commented 2 years ago

Sure, I think those were related to previous EAP changes but I can fix those

sfragata commented 2 years ago

@robert3005 now the build got 31 failed tests

robert3005 commented 2 years ago

thanks @sfragata I generally use projects CI to test things out. It appears that this is not a matter of fixing compliation errors and there's something that changed with intellij internals

robert3005 commented 2 years ago

I think this might need more updates that just what I am doing here. The tests run with latest changes, however, what's happening now is that classloaders are swapped upon loading components so the SaveActionManager that components get acccess to and the ones that's then available is a different object which then leads to test failures since it's not configured. If anyone wants to jump in go ahead but I don't see solutions other than converting to service/listeners but I only developed plugins in the post component intellij world so there might be a hack to get things working here.

fishermans commented 2 years ago

I am facing further issues. Hence, I created a new RR #392 which also includes the change mentioned here.

dubreuia commented 2 years ago

@robert3005 Thanks a lot for you work on the plugin! See #392 for resolution