search

dubreuia / intellij-plugin-save-actions

Supports configurable, Eclipse like, save actions, including "organize imports", "reformat code" and "rearrange code".
MIT License
531 stars 101 forks source link

Build for idea version 2021.3. Fixed #391 #392

Closed fishermans closed 2 years ago

fishermans commented 2 years ago

Please find my fixes for #391. Hopefully, it fixes all issues.

sfragata commented 2 years ago

LGTM @dubreuia what you think ?

fishermans commented 2 years ago

This commit seems also to be valid for 2021.2.3. I used it the whole day without any issues neither on 2021.3 nor on 2021.2.3. If desired I can downgrade the min version to 212. Please let me know.

vulinh64 commented 2 years ago

plz implement this. the stupid action on save doesn't help a lot :(

sfragata commented 2 years ago

Now I think we need to wait @dubreuia blessing :)

vulinh64 commented 2 years ago

Now I think we need to wait @dubreuia blessing :)

Did he go MIA somewhere?

fishermans commented 2 years ago

Now I think we need to wait @dubreuia blessing :)

Did he go MIA somewhere?

Meanwhile, you can build the plugin yourself locally and install it locally. Choose the gear under Plugin and select install from disk.

dubreuia commented 2 years ago

Looking, thanks for the work

fishermans commented 2 years ago

Looking, thanks for the work

Recently, I spent more time in removing all pending deprecated API calls and made the Plugin reloadable. Let me know if I should update this PR.

dubreuia commented 2 years ago

JetBrains is reviewing this update. Please expect it to be approved within two business days of the upload.

dubreuia commented 2 years ago

@sfragata @fishermans Thank you so much for your work on the plugin, I really appreciate it 🙏

I've uploaded plugin version 2.3.0 to Jetbrains plugin repo, should be up by Monday. I've tested the plugin on my side, the changes looks ok to me.

Recently, I spent more time in removing all pending deprecated API calls and made the Plugin reloadable. Let me know if I should update this PR.

@fishermans That would be great if you don't mind preparing another PR? Sorry I already merged & released this one, I wanted to push the new version ASAP. Still good to cleanup & improve

fishermans commented 2 years ago

@sfragata @fishermans Thank you so much for your work on the plugin, I really appreciate it 🙏

I've uploaded plugin version 2.3.0 to Jetbrains plugin repo, should be up by Monday. I've tested the plugin on my side, the changes looks ok to me.

Recently, I spent more time in removing all pending deprecated API calls and made the Plugin reloadable. Let me know if I should update this PR.

@fishermans That would be great if you don't mind preparing another PR? Sorry I already merged & released this one, I wanted to push the new version ASAP. Still good to cleanup & improve

You are welcome! I am using your Plugin each day. Thus, I have to say THANK YOU! I will open a new PR for further improvements next week.

sfragata commented 2 years ago

@dubreuia all cheers to @fishermans , He did the fix, I did the review ;)

Thank you for the great plugin, my team uses Eclipse and Intelj so I need to use the same formatter/organizer, so your plugin is perfect for my needs