search

dubreuia / intellij-plugin-save-actions

Supports configurable, Eclipse like, save actions, including "organize imports", "reformat code" and "rearrange code".
MIT License
531 stars 101 forks source link

231 refactoring #398

Closed fishermans closed 2 years ago

fishermans commented 2 years ago

Hi @dubreuia,

I spent some more time keeping this wonderful plugin updated.

Main change is moving to services and removing component implementation regarding https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html.

I also implemented a FileDocumentManagerListener and registering it to the EP which should be a cleaner way then using the message bus. At this point, we can decide whether to register multiple Listener for each project or using an application based listener for all projects and iterating over the projects. As long as changed documents are held systemwide, it would not make any difference from my-point-of-view.

I tested it on Idea, RubyMine and Resharper.

Please review my changes when you find some time.

BR Tiemo

fishermans commented 2 years ago

Should also fix #384 and #383

dubreuia commented 2 years ago

Thanks a lot @fishermans for those fixes 🙏 ! Merging and testing on my side, I'll try a release ASAP

Thank you to @abimarank for the review as well

EDIT: tests OK 👍

dubreuia commented 2 years ago

@fishermans - nitpicking on your pull request: you don't need to change the versions (like 2.3.1), I do it when I release I have a script which automates it (./scripts/release.sh)

Also I'm following semver so I don't increment the maintenance version for bugs / new features, here we go from 2.3.0 to 2.4.0. The version 2.3.1 would be a quick fix / hot fix or security patch (no new features)

dubreuia commented 2 years ago

https://github.com/dubreuia/intellij-plugin-save-actions/releases/tag/v2.4.0

dubreuia commented 2 years ago

Plugin uploaded pending verification, thanks again

fishermans commented 2 years ago

Thanks a lot @dubreuia!

Maybe we can clean up some of the old tickets to have a better overview of what still needs to be done.

I guess, the option "Remove unused suppressed warning annotation" should be removed as long as this function is not working as expected. It removes too much at the moment and I haven't figured out how to fix it. See #87 .