dubreuia / intellij-plugin-save-actions

Supports configurable, Eclipse like, save actions, including "organize imports", "reformat code" and "rearrange code".
MIT License
531 stars 101 forks source link

Removal of required suppress warning annotation #424

Open mipper opened 1 year ago

mipper commented 1 year ago

Describe the bug It looks like identification of unused @SuppressWarnings may not work correctly when the checkstyle plugin is also being used. The following annotation is removed incorrectly:

    @SuppressWarnings("checkstyle:ModifiedControlVariable")
    public static void method(final StringBuilder escapedValue) {
        for (int i = 0; i < escapedValue.length(); ++i) {
            if (escapedValue.charAt(i) == '"') {
                escapedValue.insert(i++, '"');
            }
        }
    }

I guess SA does't know about checkstyle. Would it be possible to ignore annotations that refer to unknown sources?

Versions Save Actions: 2.3.0

IntelliJ IDEA 2022.3.2 (Ultimate Edition) Build #IU-223.8617.56, built on January 26, 2023 Runtime version: 17.0.5+1-b653.25 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Linux 5.19.0-32-generic GC: G1 Young Generation, G1 Old Generation Memory: 2048M Cores: 16 Registry: debugger.watches.in.variables=false ide.windowSystem.autoShowProcessPopup=true

Non-Bundled Plugins: net.sf.opk.avro-schema-support (213.4.0) com.jetbrains.CyanTheme (1.3) com.dubreuia (2.3.0) CheckStyle-IDEA (5.75.0) MavenRunHelper (4.23.222.2964.0) GrepConsole (12.15.211.6693.1) PlantUML integration (5.22.0)

Kotlin: 223-1.8.0-release-345-IJ8617.56 Current Desktop: ubuntu:GNOME

KnoxasKing commented 10 months ago

As @fishermans said, unfortunately this plugin has been abandoned and therefore is incompatible with new versions of the Jetbrains IDEs.

In alternative you can use this fork:

https://plugins.jetbrains.com/plugin/21538-save-actions-tool https://github.com/wanghuan9/intellij-plugin-save-action-tool But for more information check the thread: #427