search

dubs3c / Bookie

Save all your bookmarks!
GNU General Public License v3.0
22 stars 11 forks source link

Don't require telegram username for integration #17

Open dubs3c opened 5 years ago

dubs3c commented 5 years ago

Right now, you need to have a username set on telegram in order to integrate with it. I would be better to also support just checking first- and/or last name for integration.

Maybe use the chat_id value as a unique value connected to a telegram account?

DeepikaKaranji commented 5 years ago

I'd like to work on this issue. Could you give me more information about it?

dubs3c commented 5 years ago

Sure! This issue can be a little difficult though, maybe it doesn't event work to not require a username.

The "problem" is that, when you submit a link via Telegram, Bookie needs to know which telegram message belongs to which user. Right now, I require users to set a telegram username which is unique, this username is saved in Bookie when you setup telegram integration. This way I can identify Bookie users from the Telegram HTTP message sent to Bookie.

What I want to achieve is to remove as much friction as possible by not requiring the user to set a telegram username. But Bookie somehow needs to uniquely identify correct Bookie users from a telegram message. There is some meta data in the message that Telegram services sends to Bookie, maybe that data could be used as a unique identifier, but I'm not sure.