search

dubstar-04 / Design

2D CAD For GNOME
GNU General Public License v3.0
134 stars 8 forks source link

Use GtkFileChooserNative over GtkFileChooserDialog #141

Closed Diego-Ivan closed 1 year ago

Diego-Ivan commented 1 year ago

Hello there :D

Currently, the app is using GtkFileChooserDialog, which requires explicit access to the system folders. This permission makes GNOME Software say that the app is not secure.

Captura desde 2023-02-12 00-04-58

GtkFileChooserNative uses FreeDesktop portals, so it does not have full access to all the folders, but rather only the files which it is given permission by the user.

Portals will also handle recent files, folders opened recently by the app, which are very handy features.

This dialog will eventually be deprecated too (in 4.10) by FileDialog (related to #30 ), which uses portals too, but by the moment I think it's better if the app uses as less permissions as possible :)

I will do a small self-review too, to explain some of the things I changed or removed :)

dubstar-04 commented 1 year ago

Thanks for the PR, I really appreciate it.