search

dubzzz / fast-check

Property based testing framework for JavaScript (like QuickCheck) written in TypeScript
https://fast-check.dev/
MIT License
4.25k stars 176 forks source link

Add vitest ^2 to peerDependencies of @fast-check/vitest #5114

Closed IanVS closed 1 month ago

IanVS commented 1 month ago

🚀 Feature Request

Support vitest 2.x in peerDependencies.

Motivation

I get a peer dependency warning when using vitest 2.0.1.

Vitest 2 and @fast-check/vitest are working fine in my current project, FWIW.

TomerAberbach commented 1 month ago

Funny, came here to say the same thing!

dubzzz commented 1 month ago

I was working on it recently on https://github.com/dubzzz/fast-check/pull/5108. It should be there soon

dubzzz commented 1 month ago

It seems that Vitest v2 broke part of fast-check. The broken part is around stack overflows at shrink time. While there is probably nothing to worry about, I may issue separately the bump and the peer-dep change. So far to unlock users, I'll just bump the peer stuff.

IanVS commented 1 month ago

Interesting. That sounds like a good plan. FWIW I'm using vitest 2 with fast-check right now and haven't noticed any problems so far.

dubzzz commented 1 month ago

Published at 0.1.2. I succeed into bumping without fixing anything in fast-check, it was mostly a side-effect of a change on their side but the impact is null for fast-check's users.