search

ducaale / xh

Friendly and fast tool for sending HTTP requests
MIT License
4.96k stars 90 forks source link

Disable interface name binding on some platforms #331

Closed ducaale closed 8 months ago

ducaale commented 8 months ago

Resolves #330

blyxxyz commented 8 months ago

I was about to make a PR with a feature-based solution: https://github.com/blyxxyz/xh/commit/a1599960b9ce84ad026416748cc2a9b8f33be81d

The benefit is that when network-interface gets additional platform support we don't need to change anything on our end. The downside is that it won't build by default on unsupported platforms, you do need to use --no-default-features.

ducaale commented 8 months ago

Sounds good. I'll close this PR in favour of your WIP solution👍