search

ducaale / xh

Friendly and fast tool for sending HTTP requests
MIT License
4.96k stars 90 forks source link

Update Cargo.lock #339

Closed ducaale closed 7 months ago

ducaale commented 7 months ago

This PR also raises MSRV to 1.70 and removes ~once_cell~ atty from dependencies.

blyxxyz commented 7 months ago

Perhaps we can also move from regex to regex-lite? Saves 250 KB, all the tests still pass. (It has a MSRV of 1.65 though.)

All of our regexes seem to run at most once per process on a small haystack, so it shouldn't have any performance impact. (We probably don't even get any performance benefit from that regex!() macro outside of tests.)

ducaale commented 7 months ago

...Saves 250 KB, all the tests still pass. (It has a MSRV of 1.65 though.)

Both clap and time crates weren't compiling so I had to raise our MSRV all the way to 1.70.

blyxxyz commented 7 months ago

Can't we remove once_cell as well?

ducaale commented 7 months ago

Yeah, I wanted to do that, but then I noticed that once_cell is a transitive dependency of both reqwest and syntext.

blyxxyz commented 7 months ago

Ah, I see. Probably a matter of time until they get rid of it but there's no hurry then.