search

ducaale / xh

Friendly and fast tool for sending HTTP requests
MIT License
5.64k stars 98 forks source link

Fish completion should not show file by default #340

Open chaopeng opened 1 year ago

chaopeng commented 1 year ago

version of completion script: https://github.com/ducaale/xh/blob/b694c7776b4e016cd5dfcbff42be6729fbdaa0af/completions/xh.fish

How to repro?

in fish shell type "xh ", the completion give files.

How to fix?

in the beginning of the completion script, add

complete -c xh -f

to disable file completion. See the example from fish shell: https://fishshell.com/docs/current/completions.html

I found xh is using clap to parse cli args and gen completion script. I have no experience in this lib, ValueHint maybe help.

blyxxyz commented 1 year ago

If we do that then we should make sure to add the file completion back in for options like --session. (Seems like ValueHint can be used for that.)

chaopeng commented 1 year ago 
complete -c xh -f

Only means dont hint file for "xh ". But ValueHint must be the better solution.