ducaale / xh

Friendly and fast tool for sending HTTP requests
MIT License
5.49k stars 96 forks source link

Ignore `NO_COLOR` if set to empty string #370

Closed blyxxyz closed 4 months ago

blyxxyz commented 4 months ago

Environment variables can have no value at all or they can have the empty string as a value. We used to disable color if $NO_COLOR were set at all, regardless of its value, but as of https://github.com/jcs/no_color/commit/99f90e27d0fac6a34d07998f8f577e1f2f620c61 we should ignore empty strings (and this makes more sense).

Result: NO_COLOR= xh now allows colors.