Add RG_GPIO_LED_ACTIVE_LOW option

ducalex / retro-go

Retro emulation for the ODROID-GO and other ESP32 devices

GNU General Public License v2.0

569 stars 130 forks source link

Add RG_GPIO_LED_ACTIVE_LOW option #149

Open tomvanbraeckel opened 3 months ago

tomvanbraeckel commented 3 months ago

On the Fri3d Camp 2024 badge, the RG_GPIO_LED is active low, meaning it is on when the output is 0/low and off when the output is 3V3/high.

Therefore, we need a way to invert the regular RG_GPIO_LED.

At first I used RG_GPIO_LED_INVERT but that is less descriptive than RG_GPIO_LED_ACTIVE_LOW.

ducalex commented 3 months ago

I've recently been working on improving LED, to support colors and intensity and flashing patterns. But it's not ready so for now I'm okay with merging your PR.

Though it conflicts with changes I've pushed a few days. I got rid of rg_system_set_led so your patch must be moved to update_indicators essentially.

tomvanbraeckel commented 3 months ago

Okay, I merged the dev branch and modified it as I think it should be, although I was a bit confused by the RGB functionality. Hope it's good like this?