search

ducalex / retro-go

Retro emulation for the ODROID-GO and other ESP32 devices
GNU General Public License v2.0
489 stars 114 forks source link

Numerical Battery Readout in Debug #90

Closed Cralex closed 5 months ago

Cralex commented 10 months ago

As far as I'm aware, it's possible to see the battery level in two places: over serial when connected to power and the graphical icon. I'd like to see it added to the Debug menu as well if possible. I've got two (sluggish) ports in progress and I feel that it would be helpful to be able to watch a numerical battery estimate go down over time in the menu somewhere, just to help me know if I've got the battery gauge configured correctly. (Over serial, there's a good chance it would be fully charged anyway, or I might not have it set up right and it'd show a false 0 or 100 that never changes.)

ducalex commented 10 months ago

Makes sense to me and I'm guessing it's as simple as calling rg_input_read_battery in rg_gui_debug_menu.

Do you want to do it? Or I can do it if you prefer to skip the whole PR process but I won't be able to test it right now.

Cralex commented 8 months ago

Added in my pull request. This will cause the percentage and voltage to appear in the debug menu. The menu doesn't refresh over time, so you'd need to check back if you're looking for something to change. Photo Oct 27 2023, 4 52 31 PM I had some help from AI to put this in, so it could probably be nicer with a human touch, but it's a start and it works.

ducalex commented 8 months ago

Yeah live update is possible but pretty complicated with our dialog system :(

Looking good, I left a comment on the PR just to double check something and then we can merge it.

ducalex commented 5 months ago

This was completed in PR#92.