duck-dynasty / duckbot

A Discord bot for personal friend group
GNU General Public License v3.0
9 stars 10 forks source link

start using gitmojis #390

Open Chippers255 opened 2 years ago

Chippers255 commented 2 years ago

As seen here. It might be useful to stick to an emoji standard on the commit messages and PRs. Carlos Cuesta explains here.

jameshughes89 commented 2 years ago

Oh shit, there's a standard!!

twentylemon commented 2 years ago

Not sure I'd call it a standard so much as one dude's definition. He's got a pretty website though, so he's got that going for him.

jameshughes89 commented 2 years ago

I intended to italics the standard

twentylemon commented 2 years ago

I'm not necessarily sold on the reasoning.

That said, I don't think it hurts either. It's kinda pretty, which is always nice. Searching commits may also become a little easier (eg with grep). Willing to try then I can re-evaluate after actually trying it.

I guess the actual work here is to set up a CONTRIBUTING.md and/or update the pull request template.

Chippers255 commented 2 years ago

I want to try mostly for the stylish aspect. Functionally I don't think it will make too much of a difference.

EldaveO commented 2 years ago

If we are going to implement this as standard, should I consider adding it to the duckbot wiki?

twentylemon commented 2 years ago

The wiki isn't really the place for contributing guidelines, it's better suited for user documentation. I already summarized the work that needs to be done here:

I guess the actual work here is to set up a CONTRIBUTING.md and/or update the pull request template.