search

duck7000 / imdbGraphQLPHP

5 stars 0 forks source link

movietype helper text #18

Closed GeorgeFive closed 10 months ago

GeorgeFive commented 10 months ago

Not a bug in your code, but you may want to change the help text a bit for the movietype function. This took me a few to figure out, so it may help others.

@return string movietype (TV Series, Movie, TV Episode, TV Special, TV Movie, TV Mini-Series, Video Game, TV Short, Video)

"TV Mini-Series" is supposed to be "TV Mini Series" (no dash). https://www.imdb.com/title/tt7366338/

duck7000 commented 10 months ago

Ah i see, a left over from tboothman's version i guess. I changed that now. Thanks for letting me know!

duck7000 commented 10 months ago

So the importance of a good description what every method is doing and outputting is crucial, not only in doc block but also in readme or wiki. I'll add it to the milestone file i made