search

duck7000 / imdbGraphQLPHP

5 stars 0 forks source link

photo serious bug thumb image #22

Closed duck7000 closed 10 months ago

duck7000 commented 10 months ago

I just spotted and fixed a serious bug in photo method

Thumbnail and full version where the same, now the parameter $thumb = true does get the thumbnail variant.

I spotted this because i was playing with IMDb image parameters see #21 and noticed that the images in my program are huge, some are 6mb. After checking the method i realized that there couldn't be a thumb at all..

Bug free software is a illusion hah

Edit": there are more issues, i'm working on it

Edit2: i changed CR (compression ratio) to 1 to minimize compression, it is working great now (CR means crop!)

duck7000 commented 10 months ago

I removed the image width from the parameters after @ so only height is given. This prevents that imdb changes the height to match the given width

duck7000 commented 10 months ago

I changed the image parameters again, see #21 Hopefully for good now. File size is for thumbnails around 50kb and i added QL_100 (Quality level) so the images are acceptable in quality wile keeping the file size low