search

duck7000 / imdbGraphQLPHP

5 stars 0 forks source link

Issue - Cast only returning 250 results #26

Closed GeorgeFive closed 9 months ago

GeorgeFive commented 9 months ago

This is a new issue, just noticed this today. If a movie has 250+ credits, it caps out at 250. Is there anything that can be done with this?

Example - https://www.imdb.com/title/tt8667828/fullcredits

duck7000 commented 9 months ago

Mm now you mentioned it i see it too.

I'm not sure this can be fixed, it could be the same as with episodes

Tboothman did made a different GraphQL function to get data that is paginated but i'm not sure if this will work or fix this issue. I will investigate this

GeorgeFive commented 9 months ago

Thanks.... definitely a big issue here, I think.

duck7000 commented 9 months ago

Well big or not if there is a limit and i cannot overcome it somehow we have to live with it i guess.

I will try

duck7000 commented 9 months ago

So far i have tried with the other Tboothman method and it seems sofar that i can get all cast with this method I tried the walking dead and it returns an array with 990 elements so that is promising.

A lot of the cast method has to be changed so we are not out of the woods jet

If this goes all well i might tackle the 250 limit on episode as well but no promises! Episodes is a less of a problem than cast

duck7000 commented 9 months ago

I think i fixed that 250 results limit. I uploaded the fixed methods so check it out and let me know if it is indeed fixed.

GeorgeFive commented 9 months ago

Fixed!

duck7000 commented 9 months ago

Great!

Thanks for testing