duck7000 / imdbGraphQLPHP

5 stars 0 forks source link

Config options/ remove stuff #33

Closed duck7000 closed 7 months ago

duck7000 commented 7 months ago

@jcvignoli @Tomashdoesha @GeorgeFive @All

Do you use any of the config options like ini override, language (i'm not sure this even work with GraphQL) or tweaking options?

I'm thinking of removing those, even to remove config itself as i never set anything there

Eventually i will remove all stuff that is related to the old scraping method, it isn't needed for GraphQL I doubt it will ever be used again, GraphQL isn't going away anytime soon i guess.

If you have any objections or still use anything related to above let me know

GeorgeFive commented 7 months ago

Nope, I don't use any of it. Bringing back caching to put in there would be awesome, but as it stands now, I've never touched that file.

duck7000 commented 7 months ago

Thanks for your quick reply.

If nobody else has any problems with this i will start the removal, possibly in stages.

And sorry but caching won't return as i never use it in my use case, although i do understand that your use case would benefit from caching

duck7000 commented 7 months ago

@GeorgeFive @All

I pushed a new version with all config and ini overrides removed. Please test it out, it works fine for me

GeorgeFive commented 7 months ago

Everything seems fine so far, no immediate issues pop out at me.

duck7000 commented 7 months ago

Thanks for testing! Nice to hear it works.

Source code is now a lot cleaner, no point to keep stuff if it never will be used