search

duck7000 / imdbGraphQLPHP

5 stars 0 forks source link

Renaming class names #44

Closed duck7000 closed 4 months ago

duck7000 commented 4 months ago

@All I'm thinking of renaming the following class names and file names:

Classname Person to Name Person.php to Name.php Classname PersonSearch to NameSearch PersonSearch.php to NameSearch.php

The reason is simply because imdb uses those names in their GraphQL API, so it is easier to follow their naming scheme. The second reason is to be more distinguish from imdbphp.

What is your view on this? @GeorgeFive

GeorgeFive commented 4 months ago

I'm completely neutral on this one. Won't affect me if you change it (simple fix on my end), wouldn't be upset if you left it. Your call!

duck7000 commented 4 months ago

Thanks, i already changed it hah

I released a new version with this change