duck7000 / imdbGraphQLPHP

5 stars 0 forks source link

Director = jobs #52

Closed GeorgeFive closed 2 months ago

GeorgeFive commented 2 months ago

Most credits have jobs attached to them (ie, producer, stunts, effects, etc).... but director does not have this info available. It's not very common, but it does exist in some places, ie

https://www.imdb.com/title/tt0162503/fullcredits

Any chance you could throw that in? Thanks!

duck7000 commented 2 months ago

It is very rare indeed, your example is the first i've seen so i left it out on purpose.

i will try to add it back soon, at the moment i'm still busy with all the conversion to graphQlGetAll and with the conversion of trivia and goof to categorized output array (trivia was harder than expected)

duck7000 commented 2 months ago

This is not a job but an attribute. Director and composer does not have jobs (although not impossible i guess)

I'll look in to it

GeorgeFive commented 2 months ago

Sounds good! No huge rush, just whenever you get the time.

duck7000 commented 2 months ago

@GeorgeFive I changed all methods that use directorComposer to creditHelper so they all use the same helper method.

Next i changed creditHelper to handle all different types of data (jobs, attributes and episode info) so all methods have the same output array ( but some data may not be available!)

So to sum up director, composer, writer, cinematographer, producer, stunts, thanks,specialEffects and visuealEffects all have the same output array with name, id, jobs, attributes and episode info, that does not mean all data is available but if it is there it is in the output array

So test it out!

GeorgeFive commented 2 months ago

Everything looks good! Director and composer attributes are incredibly rare, but I figured it was worth having if they offer it.

Thanks!

duck7000 commented 2 months ago

Do note that the episode info for director is not accurate as the query is missing some info i can't seem to find so best to not use that. (i doubt somebody is using this at all) All others are correct (if available)

Edit: Director is fine, writer episode info is not correct, do not use