duck7000 / imdbGraphQLPHP

7 stars 0 forks source link

Suggestion: Title, Character related, add photo URL #70

Closed jianglin8-hub closed 2 months ago

jianglin8-hub commented 2 months ago

For example, in director and writer, it would be better to include their names in the current return, along with photos of the characters

duck7000 commented 2 months ago

director and writer DO return their names in the return array, so i don't understand what you mean by this?

And include images in those method is not very useful as nobody ever asked for it and it never was included in imdbphp either.

I'll think about it

jianglin8-hub commented 2 months ago

image

I think people would like to see the name + photo of the person.

duck7000 commented 2 months ago

Mm you are now talking about cast images? the cast method DOES include image url

So you want image urls for writer, composer, director and producer as well i guess I'll think about it although i still don't think anyone, except you, will use it

jianglin8-hub commented 2 months ago

Due to language barriers, I can only communicate with you with the help of translation software. The information conveyed may be inaccurate. I am very sorry.

jianglin8-hub commented 2 months ago

Photos can help users identify people of interest more quickly. For example, I have trouble remembering their names, but I have some idea of ​​what they look like.

duck7000 commented 2 months ago

Due to language barriers, I can only communicate with you with the help of translation software. The information conveyed may be inaccurate. I am very sorry.

I understand that of course, i think you are from asia continent so language might be a problem. I'll try to be patient but please try to explain a little bit more what you mean.

duck7000 commented 2 months ago

If i can make it work i will add those image urls just as award

jianglin8-hub commented 2 months ago

If i can make it work i will add those image urls just as award

You guessed it. Thank you for your patience and contribution!

duck7000 commented 2 months ago

Image urls are added to director, producer, writer and composer in latest git commit