duck7000 / imdbGraphQLPHP

7 stars 0 forks source link

Request: Goofs #8

Closed jcvignoli closed 1 year ago

jcvignoli commented 1 year ago

Hi, Would it be possible to implement the former goofs() method in Title class? Thanks!

duck7000 commented 1 year ago

Mm i started this version to be independent and only what i absolutely needed but it is growing quickly. Is this something you definitely want or is it "nice to have"?

I'm asking because i don't want to end up whit a full blown version that is the same as imdbphp.

And i have already added some methods which i never will be using

I hope you understand that

jcvignoli commented 1 year ago

You asked me what functions do I need, goofs is one of the mehtods I do need :) I understand you may not want to implement it. I suppose your approach (graphQL) is much more stable than the previous one (regex on pages), and hope it will require less maintenance. I'd perfectly understand should you not want implement it. I will fork your version :)

duck7000 commented 1 year ago

I'm not that worried about maintenance, imdb can change their API but i think that would not happen that often as i looked at the release notes

I do worry about more and more methods that i don't use /ever going to use. But on the other side i do understand that if other users are going to use my version their needs may change. That's why i asked what you absolutely need.

Are there more methods you need?

As always, i'll think about it :)

jcvignoli commented 1 year ago

I understand. So far, there is no further method I need, but I'm in the process of checking all dead methods. Seems that's ok so far :)

duck7000 commented 1 year ago

Does goofs in or exclude spoilers, imdbphp did exclude? And do you want all goof categories or a particular one?

duck7000 commented 1 year ago

There are more users that asked for methods, which i added, but i did not notice that this request came from a different user.. Apologies

I'll see what i can do to make it work

duck7000 commented 1 year ago

i added back goofs method

check it out

jcvignoli commented 1 year ago

Works perfectly, thanks so much!

duck7000 commented 1 year ago

Thanks I had to add a sort method to sort the output array, through GraphQL i can't get them sorted EDIT: I removed this sort method as it is not compatible with older php versions see #3

I added crazyCredit as well, maybe for future use