search

duckdb / community-extensions

https://community-extensions.duckdb.org
111 stars 19 forks source link

add requires_toolchains options #50

Closed samansmink closed 2 months ago

samansmink commented 2 months ago

This option allows specifying optional extra toolchains that are required for building. So far we have only the rust toolchain. But we would like to be able to add more.

it can be specified as a ; separated list of toolchain names, that are passed straight down into duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml.

I've enabled the option for the existing extensions that depend on rust, and removed the now deprecated enable_rust option. This means that every extension added to the community extensions that needs rust, will need to specify it in its description file

samansmink commented 2 months ago

I've launched a CI run with only the PRQL one touched here https://github.com/samansmink/community-extensions/actions/runs/9908263501

I would suggest to wait for that to pass then merge this

samansmink commented 2 months ago

Ci in fork passes, so since we can't currently run multiple extensions at once we will just merge this