search

duckdb / dbt-duckdb

dbt (http://getdbt.com) adapter for DuckDB (http://duckdb.org)
Apache License 2.0
797 stars 69 forks source link

Make source tags available to plugins through the SourceConfig #228

Closed AlexanderVR closed 11 months ago

AlexanderVR commented 11 months ago

I have a custom plugin where I'd like to use the source's tags to inform the plugin load method. This MR adds the source tags as an additional SourceConfig attribute.

Additionally, when attempting to ensure existing plugin tests passed, ran into the issue that tests that should be skipped when the test profile is not md would still load the motherduck plugin and attempt a connection. This is happening because any test classes using the dbt project fixture will execute it before the skip_by_profile_type fixture, as the former is at the higher class-level scope, thus rendering the pytest.mark.skip_profile decorator ineffectual

Fix: changed skip_by_profile_type autouse fixture from function to class scope.

jwills commented 11 months ago

@AlexanderVR tags stuff LGTM obvi, but I'm puzzled by this MD test failure, does it make sense to you?

jwills commented 11 months ago

Ack okay looking more closely it looks like a token provided error, which shouldn't actually be an issue, I bet it's some dumb GH thing I haven't configured correctly