duckdb / dbt-duckdb

dbt (http://getdbt.com) adapter for DuckDB (http://duckdb.org)
Apache License 2.0
790 stars 70 forks source link

Migrate to `dbt-common` + `dbt-adapters` for v1.8+ #341

Closed jtcohen6 closed 1 month ago

jtcohen6 commented 4 months ago

Discussion:

tl;dr: Starting with dbt-core v1.8, adapters should no longer import dbt-core directly, but instead import a set of common interfaces defined in dbt-common + dbt-adapters.

I wanted to give this one a try :)

It's mostly a matter of switching import statements. I found two utility classes — SourceConfig and TargetConfig — which depend on type definitions (RuntimeConfigObject, SourceDefinition) that are not included in our common/adapter interface. I'll open a draft PR so we can take a look together & discuss.