Migrate to dbt-common + dbt-adapters

duckdb / dbt-duckdb

dbt (http://getdbt.com) adapter for DuckDB (http://duckdb.org)

Apache License 2.0

790 stars 70 forks source link

Migrate to dbt-common + dbt-adapters #342

Closed jtcohen6 closed 1 month ago

jtcohen6 commented 4 months ago

resolves #341

Starting a draft PR for discussion!

This mostly just works by updating import statements. Caveats:

In dbt.adapters.duckdb.utils: SourceConfig and TargetConfig use type definitions that are not available from the common/adapter interfaces. We could either stub those types within duckdb.utils, or discuss if they need to be pulled into the shared interfaces.
Some of the plugin tests are failing for me locally. I'd like to see if these are real issues, or just problems with my local setup.

jwills commented 3 months ago

@MichelleArk we don't need to worry about the MD one (it requires my secret token); the code quality stuff can be fixed by running pre-commit run --all-files, I'll look at the Buena Vista failure

jwills commented 2 months ago

@jtcohen6 thank you so much! Will take a look at the BV stuff which I think is broken on main as well; when does all of this need to be ready to go out the door?

jtcohen6 commented 2 months ago

@jwills Anytime in the next few weeks is good! Folks are beta-testing v1.8 now, we're planning to put out the release candidate (dbt-core==1.8.0rc1) on May 2.

jwills commented 2 months ago

just punting on this for now https://github.com/duckdb/dbt-duckdb/pull/379

jwills commented 1 month ago

@jtcohen6 this is all good, right? We're going to cut one last 1.7.x release and then merge this in /cc @guenp

jtcohen6 commented 1 month ago

@jwills ready to ship when you see fit!