search

duckdb / dbt-duckdb

dbt (http://getdbt.com) adapter for DuckDB (http://duckdb.org)
Apache License 2.0
790 stars 70 forks source link

Update `dateadd` to work with new `datediff` #347

Closed b-per closed 4 months ago

b-per commented 4 months ago

Fixes #346

Tested locally.

The model from the issue fails with 1.7.2 but works with the code from this branch,

jwills commented 4 months ago

Could we turn the model that fails into a test w/o too much trouble?

b-per commented 4 months ago

Yep, I can do that

jwills commented 4 months ago

(don't worry about the motherduck test)

b-per commented 4 months ago

I checked that the test was failing in 1.7.2 and passing locally in my branch

jwills commented 4 months ago

grateful for this @b-per