Fix https://github.com/duckdb/duckdb-java/issues/66

rpbouman commented 3 months ago

I wanted to check something around Blob handling and checked out the repo, built it, ran the tests and found two tests failing (TestDuckDBJDBC#test_all_types and TestDuckDBJDBC#test_struct_with_bad_type)

This PR fixes those tests.

For TestDuckDBJDBC#test_all_types:

This adds a check to see if the correct_answer_map has values for the column so that the column name can be reported in case the map is not populated for every column from test_all_types.
It also populates the map with the required values to allow the test to pass.

For TestDuckDBJDBC#test_struct_with_bad_type:

the assert tried to test by matching the error message with a wrong error message. Or rather, most likely the error message that was tested used to be returned by DuckDB but has changed in the mean while.

rpbouman commented 3 months ago

I'm sorry to PR test failed. I tried to figure it out but I believe the compliance action is broken, as it's complaining that it cannot find classes from the test harness itself.

Mause commented 2 months ago

I'm sorry to PR test failed. I tried to figure it out but I believe the compliance action is broken, as it's complaining that it cannot find classes from the test harness itself.

Yeah it's broken at the moment, need to get around to fixing it

Cheers for the other fixes though!

duckdb / duckdb-java

Fix https://github.com/duckdb/duckdb-java/issues/66 #67