search

duckdb / duckdb-node

MIT License
57 stars 27 forks source link

Add electron build workflow #100

Closed azmy60 closed 4 months ago

azmy60 commented 5 months ago

In attempt to support electron build as mentioned in #70.

This PR aims to build binaries for electron 18.3.x to latest.

carlopi commented 4 months ago

Thanks for the contribution, could you have a look at why CI is failing?

azmy60 commented 4 months ago

@carlopi So it was failing because I needed to add the patch version to the electron-versions.json. It should still generate binaries with the <major>.<minor> version, so 18.3.9 will generate duckdb-v1.0.1-dev14.0-electron-v18.3-linux-x64.tar.gz.

azmy60 commented 4 months ago

No problem! I just filtered 2 versions that we're currently using in our repo now. :)

carlopi commented 4 months ago

@azmy60: given you have it still fresh, could you take a look at the syntax that triggers this problem https://github.com/duckdb/duckdb-node/actions/runs/9937704658:   Error when evaluating 'strategy' for job 'osx-electron-x64'. .github/workflows/Electron.yml (Line: 167, Col: 18): Error parsing fromJson,.github/workflows/Electron.yml (Line: 167, Col: 18): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/Electron.yml (Line: 167, Col: 18): Unexpected value ''Show less