duckdb / duckdb-rs

Ergonomic bindings to duckdb for Rust
MIT License
501 stars 108 forks source link

Size of build artifacts #179

Open max-sixty opened 1 year ago

max-sixty commented 1 year ago

Hi there — we're trying to upgrade to 0.8.1. Unfortunately we're getting failures in CI about files being too big.

I see there's Windows CI on this repo, so I'm unsure why it's hitting PRQL but not here.

For context

Do you have any thoughts? Happy to wait to see whether other dependencies see similar errors.

wangfenjin commented 1 year ago

We are using msvc for the CI in this repo.

Have you ever retry?

max-sixty commented 1 year ago

We've tried msvc — that's what we've traditionally been using. CI has failed > 5 times.

It's possibly not the fault of this repo though — unless you have any immediate ideas, we can see whether other projects are successful at using 0.8.1 in CI over the next few days?

max-sixty commented 1 year ago

I think this is actually just an issue with disk space on Windows GitHub Actions Runners. We're now getting an error on 0.8.0[^1]

[^1]: (this run has less disk space available because it pulls a cache but also needs to rebuild because the cargo command changed)

A couple of links:

So unless there's some way to reduce the amount of disk space that duckdb uses in its build, we can close this. Larger projects such as PRQL might be unable to use duckdb-rs in Windows GHA.

wangfenjin commented 1 year ago

Disk should be very cheap, don't understand why github have these such a limitation 😂

wangfenjin commented 1 year ago

Or you guys can follow the the issue and use the C disk?

max-sixty commented 1 year ago

Or you guys can follow the the issue and use the C disk?

This looks more complicated than we're hoping for — we're not really testing duckdb, we're testing PRQL. So I think it's easier for us to disable using duckdb on Windows.

max-sixty commented 1 year ago

FWIW — and very possibly this is necessary, duckdb is a big project — but duckdb-rs does use lots of space!

In PRQL, after cargo clean && cargo build --features=test-dbs:


Renaming this to represent the size of the cache — but if that's not really flexible, please close!

max-sixty commented 1 year ago

FYI we're getting disk space errors in GHA on ubuntu now:

warning: ar: /home/runner/work/prql/prql/target/x86_64-unknown-linux-gnu/debug/build/libduckdb-sys-fe973d02cdbe21fe/out/libduckdb.a: No space left on device

Running the command locally:

CARGO_INCREMENTAL=0 cargo doc --features=test-dbs-external --no-deps

...leaves 2.3GB of files, o/w 1.3GB is target/debug/build/libduckdb...

...so it is using much more space than anything else.

(TBC, thank you very much for the project, and sorry to only appear when there's a problem!)