duckdb / duckdb-rs

Ergonomic bindings to duckdb for Rust
MIT License
517 stars 113 forks source link

No support for `UHUGEINT` (`u128`) in `FromSql` trait #273

Open nmlt opened 8 months ago

nmlt commented 8 months ago

It seems like support for u128 was forgotten, as u64 and i128 are supported. Is the fix as easy as adding from_sql_integral!(u128); to this file?

Edit: It's also missing for the ToSql trait.

I fixed it by following the compiler advice, but now I'll first check whether it actually works in my project. Then I'll submit a pull request.

nmlt commented 8 months ago

Hmm, looks like UHUGEINT was just added?

Anyway I'm getting a runtime crash with my code when it callsffi::duckdb_bind_uhugeint.

Mause commented 8 months ago

Unfortunately UHugeInt isn't yet supported in the arrow layer in DuckDB, but binding support would be good to have in the interim