search

duckdb / duckdb-rs

Ergonomic bindings to duckdb for Rust
MIT License
511 stars 113 forks source link

Add ability to pass vendored feature to openssl in libduckdb-sys #321

Closed muralisoundararajan closed 5 months ago

muralisoundararajan commented 5 months ago

openssl module imported from rust-openssl provides an ability to use vendored openssl as a feature. In libduckdb-sys, when it is introduced as module, the ability to provide "vendored" feature was not added to libduckdb-sys and duckdb crates.

This change adds ability to pass "vendored" feature to "openssl" module within the "libduckdb-sys"

Resolves https://github.com/duckdb/duckdb-rs/issues/320

muralisoundararajan commented 5 months ago

@Mause Thanks for the review.

CI pipeline is failing with the same reason as main line due to new version of OpenSSL 3.3.1 available in choco and runner-images for Windows is using the previous version.

By any chance, would it be possible to wait for this week duckdb release to wait till we have this issue is resolved, so that this PR can be part of the release?

Maxxen commented 5 months ago

@muralisoundararajan Its not obvious to me how to solve this issue (googling for this gives me no results). Could you share some more information from your investigation? Is this just a problem with choco that we have to wait for them to fix or can we adjust something in our CI pipeline to resolve it?

I suspect we can maybe remove the choco openssl install completely and just rely on the openssl version provided by the runner environment?

Maxxen commented 5 months ago

Actually, I think I fixed it in #327

muralisoundararajan commented 5 months ago

@Maxxen Yes, that seem to resolve the issue. Thanks for the quick turnaround.

I rebased my changes, would it be possible to run the CI workflow.

muralisoundararajan commented 5 months ago

Another option I was contemplating was to use openssl_vendored in msvc environment during the failure.

Maxxen commented 5 months ago

Thanks! Sorry for the friction :)