duckdb / duckdb-wasm

WebAssembly version of DuckDB
https://shell.duckdb.org
MIT License
1.02k stars 111 forks source link

Make target `serve_local` is broken because of missing `build_loadable_unsigned` #1663

Open isaacbrodsky opened 3 months ago

isaacbrodsky commented 3 months ago

What happens?

Make target serve_local depends on build_loadable_unsigned which is now missing, so this make target cannot be run.

I was looking for something like this because I was trying to run duckdb-wasm with extension signing off, as this is needed to test locally built extensions. (see also https://github.com/isaacbrodsky/h3-duckdb/issues/71)

To Reproduce

make serve_local

Browser/Environment:

NA

Device:

NA

DuckDB-Wasm Version:

main

DuckDB-Wasm Deployment:

NA

Full Name:

NA

Affiliation:

NA

jcolot commented 2 months ago

@isaacbrodsky I think it's closed, the build_loadable_unsigned target is now an alias of build_loadable but unsigned extensions can be loaded by using a DuckDBConfig object parameter for db.open(), after instantiation like this:

await db.instantiate(DUCKDB_CONFIG.mainModule, DUCKDB_CONFIG.pthreadWorker); await db.open({allowUnsignedExtensions: true});

jcolot commented 2 months ago

@isaacbrodsky I made an Observable notebook loading your extension h3ext

Observable notebook