search

duckdb / duckdb-wasm

WebAssembly version of DuckDB
https://shell.duckdb.org
MIT License
1.02k stars 110 forks source link

Refactor react-duckdb #1727

Open willium opened 1 month ago

willium commented 1 month ago

The existing react-duckdb providers were pretty convoluted and had properties that it didn't use. I refactored it and added documentation and comments.

I did not bump the version in package.json. This is a breaking change for this package, so I suspect it should be (part of?) a major version bump.

I may contribute some utility functions/additional hooks in the future, but these shouldn't cause breaking changes.

ncsmikewoods commented 1 week ago

I've been keeping an eye on these changes. It looks like they'll address some problems with race conditions in duckdb initialization. I've been holding off rewriting my connection management code because this refactor looks like a much cleaner implementation that's what's there.

Thanks for your work @willium