duckdb / duckdb-wasm

WebAssembly version of DuckDB
https://shell.duckdb.org
MIT License
1.02k stars 110 forks source link

Set duckdb_api #1740

Closed elefeint closed 1 month ago

elefeint commented 1 month ago

By default, "cpp" is the fallthrough option for duckdb_api. This PR sets it to wasm instead.

Before the change:

┌─────────────────────────────┐
│ user_agent                  │
╞═════════════════════════════╡
│ duckdb/v0.10.2(wasm_eh) cpp │
└─────────────────────────────┘

After the change:

duckdb> pragma user_agent;
┌──────────────────────────────┐
│ user_agent                   │
╞══════════════════════════════╡
│ duckdb/v0.10.2(wasm_eh) wasm │
└──────────────────────────────┘
carlopi commented 1 month ago

Thanks!

elefeint commented 1 month ago

@carlopi sorry, I have no idea how I could have possibly triggered this, but the previous builds seem to have been successful. Do you have ideas?

2024-05-21T16:49:48.9547308Z In file included from /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/src/arrow/ipc/feather.cc:30:
2024-05-21T16:49:48.9551757Z /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/thirdparty/flatbuffers/include/flatbuffers/flatbuffers.h:1884:12: error: overload resolution selected deleted operator '='
2024-05-21T16:49:48.9553880Z  1884 |       buf_ = other.buf_;
2024-05-21T16:49:48.9554623Z       |       ~~~~ ^ ~~~~~~~~~~
carlopi commented 1 month ago

@carlopi sorry, I have no idea how I could have possibly triggered this, but the previous builds seem to have been successful. Do you have ideas?

2024-05-21T16:49:48.9547308Z In file included from /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/src/arrow/ipc/feather.cc:30:
2024-05-21T16:49:48.9551757Z /home/runner/work/duckdb-wasm/duckdb-wasm/submodules/arrow/cpp/thirdparty/flatbuffers/include/flatbuffers/flatbuffers.h:1884:12: error: overload resolution selected deleted operator '='
2024-05-21T16:49:48.9553880Z  1884 |       buf_ = other.buf_;
2024-05-21T16:49:48.9554623Z       |       ~~~~ ^ ~~~~~~~~~~

I think I do, it has to do likely with a bump in emscripten, but I think I have the fix, will send it soon.

carlopi commented 1 month ago

I think the problem was connected to bumping arrow. Done and merged the PR, thanks!