CI: Add site build step for PRs

duckdb / duckdb-web

DuckDB website and documentation

https://duckdb.org

MIT License

162 stars 307 forks source link

CI: Add site build step for PRs #3193

Closed szarnyasg closed 3 months ago

szarnyasg commented 3 months ago

As we are now specifying links with {% link ... %} Jekyll tags, which fail the site build if the link is incorrect, it makes sense to actually check these for PRs. This will prevent broken internal links to be merged in the repository and will save time in the long run.

Mause commented 3 months ago

We already build the site in pr ci?

https://github.com/szarnyasg/duckdb-web/blob/add-pr-site-build-step/.github/workflows/jekyll.yml#L58

szarnyasg commented 3 months ago

We didn't do this for PRs. PRs only had two checks (linter), and did not attempt to build the site. See e.g. this PR yesterday: https://github.com/duckdb/duckdb-web/pull/3186