Likely setting incorrect option in aws_extension.cpp

duckdb / duckdb_aws

MIT License

34 stars 12 forks source link

Likely setting incorrect option in aws_extension.cpp #3

Closed Mytherin closed 10 months ago

Mytherin commented 10 months ago

Found by @jtigani

In aws_extension.cpp#L24 it seems s3_access_key_id is set when likely s3_secret_access_key is meant:

config.SetOptionByName("s3_access_key_id", credentials.GetAWSAccessKeyId());
config.SetOptionByName("s3_access_key_id", credentials.GetAWSSecretKey());
config.SetOptionByName("s3_session_token", credentials.GetSessionToken());

samansmink commented 10 months ago

Yea the extension is not really tested properly yet, I'll make sure this is fixed and we have some proper CI here to ensure the profile loading works before next release