search

duckdb / duckdb_azure

Azure extension for DuckDB
MIT License
51 stars 17 forks source link

liblzma patch overriding via bminor/xz #54

Closed carlopi closed 7 months ago

carlopi commented 7 months ago

portfile generated by:

  1. git clone microsoft/vcpkg
  2. cd vcpkg && git checkout a1a1cbc975abf909a6c8985a6a2b8fe20bbd9bd6
  3. copying the folder at vcpkg/ports/liblzma to vcpkg_ports/liblzma
  4. changing from tukaani-project to bminor in vcpkg_ports/portfile.cmake

See also https://github.com/microsoft/vcpkg/issues/37839

Why this is needed? This is connected to the xz-utils removal from GitHub, see this run where an unmodified duckdb_azure main branch fails to pass CI: https://github.com/carlopi/duckdb_azure/actions/runs/8525010057. With error:

error: Failed to download from mirror set
error: File does not have the expected hash:
url: https://github.com/tukaani-project/xz/archive/v5.4.4.tar.gz
File: /home/runner/work/duckdb_azure/duckdb_azure/vcpkg/downloads/tukaani-project-xz-v5.4.4.tar.gz.30321.part

After this change CI is restored to a working state.

carlopi commented 7 months ago

After feedback from @samansmink, added the commit message this comes from in the commit and PR description.

samansmink commented 7 months ago

looks good!