remove the s3 patch. kernel now has a feature (cloud) that will enable this, and since this builds with --all-features it will be enabled
@samansmink, by default this won't build in debug mode. it fails with:
duckdb_delta/duckdb/src/include/duckdb/common/helper.hpp:242:57: error: cannot ‘dynamic_cast’ ‘source’ (of type ‘const struct duckdb::MultiFileReaderGlobalState*’) to type ‘const struct duckdb::DeltaMultiFileReaderGlobalState*’ (source type is not polymorphic)
242 | D_ASSERT(reinterpret_cast<const T *>(source) == dynamic_cast<const T *>(source));
it builds fine in release mode.
my c++ foo is good enough to fix this by adding:
virtual ~MultiFileReaderGlobalState() {}
to that class, but not good enough to know if that's the correct fix or if something I've done here has broken things.
This does a few things:
cloud
) that will enable this, and since this builds with--all-features
it will be enabled@samansmink, by default this won't build in debug mode. it fails with:
it builds fine in release mode.
my c++ foo is good enough to fix this by adding:
to that class, but not good enough to know if that's the correct fix or if something I've done here has broken things.