duckdb / duckdb_delta

DuckDB extension for Delta Lake
MIT License
121 stars 14 forks source link

Build error: Could not convert ‘filtered_list’ #4

Closed kmatt closed 4 months ago

kmatt commented 4 months ago

Building with DuckDB tag: v0.10.3:

/localdata/source/duckdb_delta/src/functions/delta_scan.cpp:251:12: error: could not convert ‘filtered_list’ from ‘unique_ptr<duckdb::DeltaSnapshot,default_delete<duckdb::DeltaSnapshot>,[...]>’ to ‘unique_ptr<duckdb::MultiFileList,default_delete<duckdb::MultiFileList>,[...]>’
  251 |     return filtered_list;
      |            ^~~~~~~~~~~~~
      |            |
      |            unique_ptr<duckdb::DeltaSnapshot,default_delete<duckdb::DeltaSnapshot>,[...]>
gmake[3]: *** [extension/delta/CMakeFiles/delta_extension.dir/build.make:104: extension/delta/CMakeFiles/delta_extension.dir/src/functions/delta_scan.cpp.o] Error 1
$ make

mkdir -p build/release && \
cmake  -DEXTENSION_STATIC_BUILD=1 -DDUCKDB_EXTENSION_CONFIGS='/localdata/source/duckdb_delta/extension_config.cmake'  -DOSX_BUILD_ARCH=  -DDUCKDB_EXPLICIT_PLATFORM=''  -DCMAKE_BUILD_TYPE=Release -S "./duckdb/" -B build/release && \
cmake --build build/release --config Release
-- git hash 70fd6a8a24, version v0.10.3, extension folder v0.10.3
-- Extensions will be deployed to: /localdata/source/duckdb_delta/build/release/repository
fatal: No names found, cannot describe anything.
-- Load extension 'delta' from '/localdata/source/duckdb_delta' @ 7236aa4
-- Load extension 'httpfs' from '/localdata/source/duckdb_delta/duckdb/extensions' @ 70fd6a8a24
-- Load extension 'parquet' from '/localdata/source/duckdb_delta/duckdb/extensions' @ 70fd6a8a24
-- Load extension 'jemalloc' from '/localdata/source/duckdb_delta/duckdb/extensions' @ 70fd6a8a24
CMake Warning at CMakeLists.txt:1157 (message):
  Extension 'delta' has a vcpkg.json, but build was not run with VCPKG.  If
  build fails, check out VCPKG build instructions in
  'duckdb/extension/README.md' or try manually installing the dependencies in
  /localdata/source/duckdb_deltavcpkg.json

CMake Warning at CMakeLists.txt:1157 (message):
  Extension 'httpfs' has a vcpkg.json, but build was not run with VCPKG.  If
  build fails, check out VCPKG build instructions in
  'duckdb/extension/README.md' or try manually installing the dependencies in
  /localdata/source/duckdb_delta/duckdb/extension/httpfsvcpkg.json

-- Extensions linked into DuckDB: [delta, httpfs, parquet, jemalloc]
-- Tests loaded for extensions: [delta]
-- Configuring done
...
samansmink commented 4 months ago

The delta kernel upstream has made some changes that broke the build, those will be fixed in the near future.

In the meantime the delta extension binaries have been published for 0.10.3 and i've pinned the delta kernel version to a fixed commit in the build which should resolve this issue for now.

Let me know if you run into anything else!