search

duckdb / duckdb_iceberg

MIT License
107 stars 18 forks source link

Change yyjson_get_tag() to yyjson_get_type() when doing type comparisons. #50

Closed rustyconover closed 1 month ago

rustyconover commented 2 months ago

fix: change yyjson comparisions to type rather than tag.

Many comparisons were performed using yyjson_get_tag() rather than yyjson_get_type(). The tag can have additional information set using bits beyond just the type, causing these type comparisons to fail and parsing the metadata to fail.

fix: fix the extension to build with current duckdb main branch.

Fix a few std::move() calls and a call to fs.OpenFile().

harel-e commented 1 month ago

Issue #39 is fixed with this PR

samansmink commented 1 month ago

Looks good to me, thanks a lot!