Closed peterboncz closed 3 months ago
windows CI is failing due to some upstream issue, however the tests also seem to fail due to only the json metadata files being added and not the avro and parquet files
windows CI is failing due to some upstream issue, however the tests also seem to fail due to only the json metadata files being added and not the avro and parquet files
apologies for that messup. I have made the name change and made sure all files are pushed now.
Thanks for the changes! looks good!
Commit the generated data into the repo, because this facilitates running the tests in CI (since generating the data requires to equip the test runners with pyspark, which at least motherduck prefers not to).
The data is minimized to 5MB, by setting the scale factor 10x smaller, and from expected_results/ only keeping last/. This motivates rewriting some testcases that used expected_results/q08 into expected_results/last (which is the same)
Removed one testcase, which tests if we get an error when parquet is not loaded (in MotherDuck, when we run iceberg in so-called "remote_only" mode, this will actually not raise an error). It was kind of a trivial test, so I hope this is OK..