search

duckdb / duckdb_spatial

MIT License
492 stars 41 forks source link

Geometry Polygon::CreateFromBox has a typo in v0.10.2 branch #312

Closed ahuarte47 closed 6 months ago

ahuarte47 commented 7 months ago

https://github.com/duckdb/duckdb_spatial/blob/a62e73ce80db4e136bd169535e2687909fbb048a/spatial/include/spatial/core/geometry/geometry.hpp#L800

I think this should be:

LineString::SetVertex(ring, 1, {minx, maxy});

Maxxen commented 6 months ago

Thanks! Good catch! I've pushed a fix for it.

ahuarte47 commented 6 months ago

I am closing, fix merged. Thanks @Maxxen