duckdb / duckdb_spatial

MIT License
489 stars 40 forks source link

Bugfixes & improve RTree delete performance #397

Closed Maxxen closed 2 months ago

Maxxen commented 2 months ago

This PR fixes some minor bugs found by ASAN in the shape file reader and the geometry dimension conversion code.

It also fixes an issue that caused deletes in the RTree to delete the wrong entry or silently fail to delete at all. I've also made a fix so that the delete code will actually use the rtree bounding boxes to prune out candidates when searching for the entry to remove, improving performance considerably.

This PR also adds a basic internal RTree::Print() function to aid in debugging.