Closed DrewScatterday closed 1 month ago
Hi! Thanks for reporting this issue!
My first hunch is that this is related to https://github.com/duckdb/duckdb/issues/13848#issuecomment-2352674000, but the fact that it only crashes when you instantiate the r-tree index is strange... We run the r-tree tests as part of our CI on windows, so maybe it's node related? I'll try to have a look tomorrow.
Thanks @Maxxen !! Let me know what you find out
I can test on a Ubuntu WSL node js env just to help sanity check
Code works with no issues on Ubuntu 22.04.02 and same version of node (20.11.1)
So definitely a windows issue and not a rtree bug hmmm
I tried installing the nightly version of duckdb on winodws with npm install duckdb@next
but the cmd window seems to just hang:
[##################] - reify:duckdb: timing reify:audit Completed in 276ms
edit: uninstalled duckdb and then installed with npm install duckdb@next
and then still got the same issue
The duckdb version that gets installed with npm install duckdb@next
is "duckdb": "^1.0.1-dev27.0"
. Was still getting this issue on that version.
I followed the thread in the issue you linked and did the following:
14.40.33810.0
.duckdb/extensions
npm install duckdb
I then still got same issue
I also tried reinstalling spatial extension with FORCE INSTALL spatial FROM core_nightly;
but I still get that weird error message I got above
@DrewScatterday: duckdb-node has been updated, now the DuckDB library is at version v1.1.1. This brings in quite a few changes both DuckDB and spatial extension side, so it's possible that the situation regarding this bug has changed.
Could you possibly try to install https://www.npmjs.com/package/duckdb/v/1.1.1-dev3.0, and re-run the previous test?
Thanks a lot!
Hey @carlopi thanks for your hard work on duckdb!!
Unfortunately I still get the same issue, let me know if you are able to reproduce. I'm wondering if its something fishy with the spatial extension binary for Windows?
"duckdb": "^1.1.1-dev3.0"
and also deleted the 1.1.0 extensions folder in .duckdb/extensions14.40.33810.0
INSTALL spatial FROM core_nightly;
but still no luck there eitherThanks for the info, we will dig a bit deeper and get to the bottom of this.
Any updates on this? are you guys able to reproduce this? @Maxxen @carlopi thank you for your hard work!!
Hello! I've been able to reproduce it, but yeah it only crashes on the specific combination of windows+node. windows+python seems fine. I've spent about a day looking into this but debugging node on windows is extremely time consuming as almost any change requires a full-recompilation and the windows machines we have access to are either under-powered or impose a completely different DX to what we're used to. This is of course something we want to fix so I am going to investigate this further but I can't provide an exact timeline.
Totally understand Windows is a giant pain haha
Keep me posted and if there is anything I can help test let me know
Debugging this almost killed me, but I learned a lot about windows and I think I got a fix for this in https://github.com/duckdb/duckdb-node/pull/127 :). Should hopefully make in for DuckDB v1.1.2
Hahaha thanks @Maxxen you're a legend!!
If it were up to me I wouldn't touch windows with a 10 ft pole but unfortunately the project I'm working on has other dependencies on Windows. Thanks again for looking into this, can I test it on the nightly build?
@DrewScatterday: a pre-release version of duckdb-node is being built, it should be up in a couple of hours.
Can you possibly then double check whether this works? This will then next week be released as 1.1.2
.
Thanks everyone, and amazing bug hunt from @Maxxen
Yes I'll test as soon as I can on nightly thanks guys!
Duckdb-node nightly version is here: https://www.npmjs.com/package/duckdb/v/1.1.2-dev4.0 (on duckdb v1.1.1)
on 1.1.2-dev4.0 the issue is fixed on my side thanks again for your hardwork! π π₯³
Hi! Thanks for your hardwork on DuckDB absolutely loving it in my day to day spatial data work.
I think this may be be related to #391 but not sure. I think I found a bug with r-tree indexing. I'm using example code from this article https://duckdb.org/docs/extensions/spatial/r-tree_indexes#example
I'm using node.js 20.11.1, Windows 10, and duckdb 1.1.0
If I run this code, it dies with no error thrown:
If I remove the r-tree index, it works with no problem:
Output:
I also tried using nightly build:
I get this as the error message:
Any ideas, am I missing something?