search

duckdb / extension-template

Template for DuckDB extensions to help you develop, test and deploy a custom extension
MIT License
144 stars 48 forks source link

Process for upgrading Duck version #81

Open varunkumar opened 2 months ago

varunkumar commented 2 months ago

What is the recommended process for upgrading duckdb and extension-ci-tools submodules? I have changed the duckdb stable version in .github/workflows/MainDistributionPipeline.yml as mentioned in README. I believe this will take care of the builds on the GitHub. For the local environment, do we have to pull the changes from the submodules explicitly?

samansmink commented 2 months ago

Thanks for opening this one @varunkumar, the doc lives in https://github.com/duckdb/extension-template/blob/main/docs/UPDATING.md but could use some updating, check out the updated one in my open PR here: https://github.com/duckdb/extension-template/pull/80/commits/07c7d7a18c9161ff002d824bfa124005d917b45a

varunkumar commented 2 months ago

the reusable workflow duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml for the duckdb-stable-build job should be set to latest tagged release

Can you please elaborate on this?

Changing the version uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.0.0 to uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.1.0 is good enough right?

samansmink commented 2 months ago

@varunkumar yep that's correct